[BUGFIX] argilla: prevent enum literal validation errors
#5679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frascuchon
commented
Nov 7, 2024
| @@ -122,13 +121,12 @@ def __init__( | |||
| super().__init__(client=client) | |||
|
|
|||
| try: | |||
| settings = TermsMetadataPropertySettings(values=options, type=MetadataPropertyType.terms) | |||
| settings = TermsMetadataPropertySettings(values=options) | |||
There was a problem hiding this comment.
We don't need the type here anymore. Each setting instance defines its type.
frascuchon
commented
Nov 7, 2024
| except ValueError as e: | ||
| raise MetadataError(f"Error defining metadata settings for {name}") from e | ||
|
|
||
| self._model = MetadataFieldModel( | ||
| name=name, | ||
| type=MetadataPropertyType.float, |
There was a problem hiding this comment.
This type is redundant. Model should use the one defined under the settings attribute
frascuchon
changed the title
argilla: prevent enum literal validationsargilla: prevent enum literal validation errors
jfcalvo
approved these changes
Dec 11, 2024
frascuchon
deleted the
bugfixes/argilla/prevent-enum-literal-validations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some environments, working with enun instances as string values may lead to some validation errors. See this discord discussion.
This PR reviews how metadata settings classes are defined, and defines type directly as a literal string, in the same way we do fo questions or fields, instead of using the MetadataPropertyType class.
Type of change
How Has This Been Tested
Checklist