Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Using search engine to compute the total number of records for user metrics #5641

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

frascuchon
Copy link
Member

Description

Using search engine total instead of DB count to get the total number of records. This improves the performance when running the Argilla server on an HF space with persistent storage enabled.

Type of change

  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon requested a review from jfcalvo October 28, 2024 15:31
@frascuchon frascuchon merged commit 9bc6ff3 into develop Oct 28, 2024
2 of 3 checks passed
@frascuchon frascuchon deleted the perf/compute-total-records-from-search-engine branch October 28, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants