Import from hub docs #5631
Merged
Import from hub docs #5631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eld to at least one field (required or not) (#5569) # Description In this PR we are changing how dataset publish validation works moving from: * At least one required field to be a valid publishable dataset. To: * At least one field (required or not) to be a valid publishable dataset. Refs argilla-io/roadmap#21 **Type of change** - New feature (non-breaking change which adds functionality) **How Has This Been Tested** - [x] Modifying test suite. **Checklist** - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
# Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> This PR removes name pattern validation for field, question, metadata-property and vector-settings **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Refactor (change restructuring the codebase without changing functionality) - Improvement (change adding some improvement to an existing functionality) **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
for more information, see https://pre-commit.ci
…lla-io/argilla into feat/create-dataset-from-ui
…lla-io/argilla into feat/create-dataset-from-ui
burtenshaw
reviewed
Oct 25, 2024
burtenshaw
reviewed
Oct 25, 2024
# Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> This PR fixes problems when a class label sequence is mapped as suggestions. NOTE: This PR does not infer a sequence of class labels as multi-label questions. Only prevent errors when a sequence of class labels column is used as a suggestion (or other kinds of properties in argilla) **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Bug fix (non-breaking change which fixes an issue) **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
Co-authored-by: burtenshaw <[email protected]>
Solved! |
sdiazlor
reviewed
Oct 28, 2024
There was a problem hiding this comment.
Just some comments as a person with little knowledge of this feature and is taking a first look.
- As the quickstart, I'd say to change the title of "Import a dataset from the Hub" to something more direct as it can be confusing for someone who doesn't know about Argilla. I'd say to use here "Create your first dataset", and that section remove it, adding just a note as Ben suggested and including SDK related stuff in a "Using the python SDK", similarly to "Deploy with Docker" where only it is mentioned and redirected. Or even combining the "importing long dataset" issue and the sdk further configuration/creation mention.
- I'll move the image after Fields and Questions so people can understand what they see.
- Not sure but regarding the Dataset Settings update, isn't it after giving it a name? I'd use a note or move it after that if that's the case.
- About workspaces, I'd keep the "About workspaces" as it seems it must be manually added and it's not automatically inferred?
- If this is the unique doc related to importing from the UI, it would be worthy to mention others like what about vectors or metadata, as those already knowing Argilla will have to check.
Base automatically changed from
feat/create-dataset-from-ui
to
feat/argilla-direct-feature-branch
October 29, 2024 09:02
Base automatically changed from
feat/argilla-direct-feature-branch
to
develop
October 29, 2024 09:47
frascuchon
reviewed
Oct 29, 2024
|
Docs for this PR have been deployed hidden from versioning: https://docs.argilla.io/docs_ui-import-from-hub |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #<issue_number>
Type of change
How Has This Been Tested
Checklist