-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PERF][IMPROVEMENT] argilla server: improve computation for dataset progress and metrics #5618
Merged
frascuchon
merged 8 commits into
develop
from
perf/argilla-server/improve-computation-for-dataset-progress-and-metrics
Oct 23, 2024
Merged
[PERF][IMPROVEMENT] argilla server: improve computation for dataset progress and metrics #5618
frascuchon
merged 8 commits into
develop
from
perf/argilla-server/improve-computation-for-dataset-progress-and-metrics
Oct 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5618 +/- ##
===========================================
- Coverage 91.22% 91.21% -0.02%
===========================================
Files 145 145
Lines 6051 6065 +14
===========================================
+ Hits 5520 5532 +12
- Misses 531 533 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
41f2a1e
to
71f0c99
Compare
jfcalvo
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Computing dataset progress and metrics using the search engine drastically reduces the time required to run the Argilla server in HF spaces when persistent storage is enabled.
TODO
Type of change
How Has This Been Tested
Checklist