Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] argilla server: Prevent convert ChatFieldValue objects #5605

Conversation

frascuchon
Copy link
Member

Description

Changes introduced in #5600 include a but when the fields in the RecordCreate schema already contain ChatFieldValue object. This is the cause of failing integration tests in the develop branch.

The custom validator must skip these objects even if the pre flag is set to True.

This PR fixes the error.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon requested a review from jfcalvo October 17, 2024 08:33
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.23%. Comparing base (de153ea) to head (59a8e39).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5605      +/-   ##
===========================================
+ Coverage    91.21%   91.23%   +0.01%     
===========================================
  Files          145      145              
  Lines         6036     6036              
===========================================
+ Hits          5506     5507       +1     
+ Misses         530      529       -1     
Flag Coverage Δ
argilla-server 91.23% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jfcalvo jfcalvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@frascuchon frascuchon merged commit 134f5a3 into develop Oct 17, 2024
5 of 6 checks passed
@frascuchon frascuchon deleted the bugfix/argilla-server/prevent-error-with-chat-field-value-objects branch October 17, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants