Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] argilla server: moving all record validators #5603

Merged

Conversation

frascuchon
Copy link
Member

Description

This PR moves all the record relationship validations (suggestions, responses, and vectors) inside the record validator. This helps centralize the validations and prevents objects from flushing into the DB early.

Type of change

  • Refactor (change restructuring the codebase without changing functionality)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon requested a review from jfcalvo October 16, 2024 16:09
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.22%. Comparing base (8b959c5) to head (9b4b0a7).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5603      +/-   ##
===========================================
- Coverage    91.22%   91.22%   -0.01%     
===========================================
  Files          145      145              
  Lines         6030     6051      +21     
===========================================
+ Hits          5501     5520      +19     
- Misses         529      531       +2     
Flag Coverage Δ
argilla-server 91.22% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frascuchon frascuchon changed the title [DRAFT] [REFACTOR] argilla server: moving all record validators [REFACTOR] argilla server: moving all record validators Oct 17, 2024
@frascuchon frascuchon merged commit 668643c into develop Oct 17, 2024
5 of 6 checks passed
@frascuchon frascuchon deleted the refactor/argilla-server/moving-all-record-validators branch October 17, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants