Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support to other than str values for terms metadata properties #5594

Merged

Conversation

frascuchon
Copy link
Member

Description

This PR adapts the SDK to support changes included in #5589. This allows to define terms metadata properties with other values than str (boolean, a set of integers,...)

Type of change

  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon requested a review from burtenshaw October 11, 2024 09:40
Copy link
Contributor

@burtenshaw burtenshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@frascuchon frascuchon merged commit 8b959c5 into develop Oct 11, 2024
6 of 7 checks passed
@frascuchon frascuchon deleted the feat/support-other-than-str-options-for-terms-metadata branch October 11, 2024 09:48
@frascuchon frascuchon restored the feat/support-other-than-str-options-for-terms-metadata branch October 14, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants