Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of USERNAME and PASSWORD to environment variables to create Owner user. #5506

Merged
merged 10 commits into from
Sep 24, 2024

Conversation

bikash119
Copy link
Contributor

Included default username/password to environment variable to create owner user.

Description

  • Added USERNAME and PASSWORD to the environment variables. This change will allow the user to login to Argilla UI with owner user credentials.

Closes #5434

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

In dev machine

  • install minikube ( local k8s cluster)
  • Create k8s resources ( kubect apply -f <resource.yaml> )
  • Configure port forwarding ( kubectl port-forward service/argilla-server 6900:6900 )
  • Open Argilla UI ( http://localhost:6900)
  • Login with username: argilla , password : 12345678
  • The user will get authenticated and will be redirected to http://localhost:6900/datasets screen.

Checklist

  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

Copy link
Member

@davidberenstein1957 davidberenstein1957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this looks good. Can you also confirm this has been added to the right documentation in the argilla-server directory and potentially also argilla docs itself. https://docs.argilla.io/latest/reference/argilla-server/configuration/
and the readme for the server. Thanks for the contribution :)

@davidberenstein1957
Copy link
Member

@bikash119
Copy link
Contributor Author

https://docs.argilla.io/latest/reference/argilla-server/configuration/
hi @davidberenstein1957 : I have updated the documentation as suggested. Please share your feedback.

Copy link
Member

@davidberenstein1957 davidberenstein1957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bikash119, one more remark. After that, I will merge the PR :)

bikash119 and others added 4 commits September 24, 2024 13:38
Commented the USERNAME and PASSWORD field. This will enforce users to set USERNAME and PASSWORD for Owner explicitly. 
Thank you @david for the review comments.
@davidberenstein1957 davidberenstein1957 merged commit 56efd57 into argilla-io:develop Sep 24, 2024
0 of 6 checks passed
@davidberenstein1957 davidberenstein1957 added this to the v2.3.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] add USERNAME and PASSWORD environment variables to create the owner user.
2 participants