Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ArgillaTrainer for unified variable usage #4214

Merged

Conversation

davidberenstein1957
Copy link
Member

@davidberenstein1957 davidberenstein1957 commented Nov 14, 2023

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Closes #4029

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • New feature (non-breaking change which adds functionality)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

N.A.

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@davidberenstein1957 davidberenstein1957 marked this pull request as ready for review November 14, 2023 08:33
Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4214-ki24f765kq-no.a.run.app

@davidberenstein1957 davidberenstein1957 force-pushed the feat/refactor-argilla-trainer-for-unified-usage branch from 0ecdbb3 to 513e1db Compare November 14, 2023 14:19
…evelop

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 325 lines in your changes are missing coverage. Please review.

Comparison is base (321be18) 65.06% compared to head (a8c1928) 64.75%.
Report is 6 commits behind head on develop.

❗ Current head a8c1928 differs from pull request most recent head 3c3d820. Consider uploading reports for the commit 3c3d820 to get more accurate results

Files Patch % Lines
...c/argilla/client/feedback/training/schemas/base.py 39.89% 110 Missing ⚠️
src/argilla/training/spacy.py 0.00% 32 Missing ⚠️
src/argilla/training/openai.py 0.00% 31 Missing ⚠️
src/argilla/training/transformers.py 0.00% 30 Missing ⚠️
src/argilla/training/setfit.py 0.00% 24 Missing ⚠️
src/argilla/client/feedback/training/base.py 32.25% 21 Missing ⚠️
src/argilla/training/base.py 45.71% 19 Missing ⚠️
...argilla/client/feedback/training/frameworks/trl.py 0.00% 18 Missing ⚠️
src/argilla/training/peft.py 0.00% 10 Missing ⚠️
src/argilla/training/span_marker.py 0.00% 9 Missing ⚠️
... and 7 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4214      +/-   ##
===========================================
- Coverage    65.06%   64.75%   -0.31%     
===========================================
  Files          319      321       +2     
  Lines        18473    18494      +21     
===========================================
- Hits         12019    11976      -43     
- Misses        6454     6518      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidberenstein1957 davidberenstein1957 merged commit b8fb3e4 into develop Nov 19, 2023
@davidberenstein1957 davidberenstein1957 deleted the feat/refactor-argilla-trainer-for-unified-usage branch November 19, 2023 10:25
leiyre pushed a commit that referenced this pull request Nov 29, 2023
* develop: (30 commits)
  chore: increase dev version release to 1.21.0
  fix: responses and suggestions filter QA (#4337)
  feat: delete suggestion from record on search engine (#4336)
  feat: update suggestion from record on search engine (#4339)
  bug: fix bug and update test (#4341)
  fix: preserve `TextClassificationSettings.label_schema` order (#4332)
  Update issue templates
  feat: 🚀 support for filtering and sorting by responses and suggestions (#4160)
  fix: handling errors for non-existing endpoints (#4325)
  feat: adding utils module and functions (#4121)
  Update labels in github workflows (#4315)
  fix: correct unification implementation for `RankingQuestionStrategy` (#4295)
  fix: update to solve the error of integration tests in CI (#4314)
  docs: revisit install process (#4261)
  feat: increase timeout minutes for python tests (#4307)
  docs: docs export dataset does not apply coloring for code snippets (#4296)
  docs: update final section of the rag haystack blog post (#4294)
  feat: add multi_modal templates and update vector setting (#4283)
  feat: better logging bar for FeedbackDataset (#4267)
  refactor: ArgillaTrainer for unified variable usage (#4214)
  ...

# Conflicts:
#	frontend/v1/infrastructure/repositories/RecordRepository.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] refactor ArgillaTrainer
2 participants