refactor: Using the metadata.name instead metadata.id for search index
#3994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frascuchon
changed the title
metadata.name instead metadata.id for search index
for more information, see https://pre-commit.ci
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
|
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3994-ki24f765kq-no.a.run.app |
…for-search-engine-index
for more information, see https://pre-commit.ci
frascuchon
deleted the
refactor/use-metadata-name-instead-of-id-for-search-engine-index
branch
damianpumar
pushed a commit
that referenced
this pull request
Oct 24, 2023
…index (#3994) <!-- Thanks for your contribution! As part of our Community Growers initiative 🌱, we're donating Justdiggit bunds in your name to reforest sub-Saharan Africa. To claim your Community Growers certificate, please contact David Berenstein in our Slack community or fill in this form https://tally.so/r/n9XrxK once your PR has been merged. --> # Description This PR changes how metadata info is indexed in Elasticsearch, by using names instead of ids. The aim of this code refactoring is to make raw indexes more user-friendly and let the possibility of using the Lucene query DSL for filtering data from Argilla (as we already do for other tasks). --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes how metadata info is indexed in Elasticsearch, by using names instead of ids. The aim of this code refactoring is to make raw indexes more user-friendly and let the possibility of using the Lucene query DSL for filtering data from Argilla (as we already do for other tasks).