feat: add last_activity_at to feedback datasets
#3992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@damianpumar please feel free to add here the frontend changes, using this new dataset attribute instead of Once it's done please set the PR as ready for review. |
|
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3992-ki24f765kq-no.a.run.app |
Codecov ReportAll modified lines are covered by tests ✅ see 292 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
…ttps://github.com/argilla-io/argilla into feature/add-last-activity-at-to-feedback-datasets
From my side is done! |
gabrielmbmb
reviewed
Oct 19, 2023
src/argilla/server/alembic/versions/26721800a9f3_add_last_activity_at_to_datasets_table.py
Outdated
Show resolved
Hide resolved
frascuchon
reviewed
Oct 19, 2023
frascuchon
changed the title
last_activity_at to feedback datasets
gabrielmbmb
approved these changes
Oct 19, 2023
frascuchon
approved these changes
Oct 19, 2023
damianpumar
added a commit
that referenced
this pull request
Oct 24, 2023
# Description This PR adds a new `DateTime` column to `datasets` table with name `last_activity_at`. This new column will be updated for the following cases: * When a dataset is created or updated. * When a response for a record belonging to the dataset has been created, updated or deleted. The idea is that we can use `last_activity_at` to record the last time that an activity associated with a dataset happened and use it instead of `updated_at` to show recent activity on the UI. Closes #3981 **Type of change** - [x] New feature (non-breaking change which adds functionality) **How Has This Been Tested** - [x] Adding new tests and running them locally. - [x] Running tests using PostgreSQL locally. **Checklist** - [ ] I added relevant documentation - [x] follows the style guidelines of this project - [x] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [ ] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: Damián Pumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new
DateTimecolumn todatasetstable with namelast_activity_at.This new column will be updated for the following cases:
The idea is that we can use
last_activity_atto record the last time that an activity associated with a dataset happened and use it instead ofupdated_atto show recent activity on the UI.Closes #3981
Type of change
How Has This Been Tested
Checklist