fix: add missing question update validations #3967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmbmb
approved these changes
Oct 17, 2023
Comment on lines
+317
to
+323
| QuestionName = Annotated[ | ||
| constr( | ||
| regex=QUESTION_CREATE_NAME_REGEX, | ||
| min_length=QUESTION_CREATE_NAME_MIN_LENGTH, | ||
| max_length=QUESTION_CREATE_NAME_MAX_LENGTH, | ||
| ) | ||
| title: constr( | ||
| ), | ||
| PydanticField(..., description="The name of the question"), |
There was a problem hiding this comment.
maybe we can move the regex, min_length and max_length to the PydanticField and use str instead of constr
There was a problem hiding this comment.
at some point we're going to have to do it anyway: https://docs.pydantic.dev/latest/migration/#constrained-types
There was a problem hiding this comment.
Yes, we should do it for all of the annotated fields once we move to v2.
|
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3967-ki24f765kq-no.a.run.app |
frascuchon
reviewed
Oct 17, 2023
…o fix/fix-question-update-validations
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
frascuchon
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the following changes:
titleanddescriptionare using the same validations for update and create.settingsis now a non nullable field when updating.titleandvisible_for_annotatorsare now non nullable fields when updating.Type of change
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests)Checklist