Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add add_metadata_property to both FeedbackDataset and RemoteFeedbackDataset #3900

Merged
merged 24 commits into from
Oct 11, 2023
Merged

feat: add add_metadata_property to both FeedbackDataset and RemoteFeedbackDataset #3900

merged 24 commits into from
Oct 11, 2023

Conversation

alvarobartt
Copy link
Member

@alvarobartt alvarobartt commented Oct 9, 2023 •
edited
Loading

Description

This PR implements the method add_metadata_property to both FeedbackDataset and RemoteFeedbackDataset (i.e. FeedbackDataset in Argilla) so that an user with either admin or owner role can add a new metadata_property to either a local FeedbackDataset or to an existing FeedbackDataset in Argilla.

Closes #3898

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

  • Add integration tests for add_metadata_property method in RemoteFeedbackDataset
  • Add unit/integration tests for add_metadata_property method in FeedbackDataset

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@alvarobartt alvarobartt added type: enhancement Indicates new feature requests client labels Oct 9, 2023
@alvarobartt alvarobartt added this to the v1.17.0 milestone Oct 9, 2023
@alvarobartt alvarobartt self-assigned this Oct 9, 2023
@alvarobartt alvarobartt mentioned this pull request Oct 9, 2023
Closed
@alvarobartt
Merge branch 'feature/support-for-metadata-filtering-and-sorting' of …
8d5bc53 
…github.com:argilla-io/argilla into feat/add-metadata-properties-to-existing
@alvarobartt alvarobartt marked this pull request as ready for review October 10, 2023 08:36
@alvarobartt alvarobartt marked this pull request as draft October 10, 2023 08:36
@alvarobartt alvarobartt changed the title feat: add add_metadata_properties to RemoteFeedbackDataset feat: add add_metadata_property to both FeedbackDataset and RemoteFeedbackDataset Oct 10, 2023
@alvarobartt alvarobartt marked this pull request as ready for review October 10, 2023 13:15
@github-actions
Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3900-ki24f765kq-no.a.run.app

gabrielmbmb
gabrielmbmb approved these changes Oct 10, 2023
View reviewed changes
alvarobartt and others added 3 commits October 10, 2023 17:24
@alvarobartt @gabrielmbmb
fix(style): replace super() with self
e464e94 
Co-authored-by: Gabriel Martín Blázquez <[email protected]>
@alvarobartt @gabrielmbmb
fix(docs): typo and missing docstring
cf4b02c 
Co-authored-by: Gabriel Martin <[email protected]>
@alvarobartt
refactor: _validate to _unique
e79c5c6 
The method `_validate_metadata_property` is now `_unique_metadata_property`
@alvarobartt alvarobartt linked an issue Oct 11, 2023 that may be closed by this pull request
[FEATURE] Add metadata_properties to any FeedbackDataset in Argilla #3898
Closed
@codecov
Copy link

codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/argilla/client/feedback/dataset/base.py 63.44% <100.00%> (+1.21%) ⬆️
src/argilla/client/feedback/dataset/local.py 72.72% <100.00%> (+4.87%) ⬆️
src/argilla/client/feedback/schemas/metadata.py 91.60% <ø> (ø)
.../argilla/client/feedback/dataset/remote/dataset.py 38.55% <16.66%> (-3.70%) ⬇️

... and 6 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@alvarobartt
Merge branch 'feature/support-for-metadata-filtering-and-sorting' of …
0ef5f0a 
…github.com:argilla-io/argilla into feat/add-metadata-properties-to-existing
@alvarobartt
Merge branch 'feature/support-for-metadata-filtering-and-sorting' of …
91a81e2 
…github.com:argilla-io/argilla into feat/add-metadata-properties-to-existing
@alvarobartt alvarobartt merged commit 7c2030d into feature/support-for-metadata-filtering-and-sorting Oct 11, 2023
@alvarobartt alvarobartt deleted the feat/add-metadata-properties-to-existing branch October 11, 2023 15:15
@frascuchon frascuchon modified the milestones: v1.17.0, v1.18.0 Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielmbmb gabrielmbmb gabrielmbmb approved these changes

@frascuchon frascuchon Awaiting requested review from frascuchon

Assignees

@alvarobartt alvarobartt

Labels
type: enhancement Indicates new feature requests
Projects
None yet
Milestone
v1.18.0
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add metadata_properties to any FeedbackDataset in Argilla
3 participants
@alvarobartt @gabrielmbmb @frascuchon