Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add total records when fetching records with metadata filter #3848

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Sep 28, 2023

Description

This PR includes the total number of records when some metadata filter is applied for endpoints /api/v1/me/datasets/:dataset_id/records and /api/v1/datasets/:dataset_id/records

In the future, this value will be computed for all cases and not only when metadata_filter is applied

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • New feature (non-breaking change which adds functionality)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon merged commit 1ee07e7 into feature/support-for-metadata-filtering-and-sorting Sep 28, 2023
@frascuchon frascuchon deleted the feat/add-total-records-when-fetching-records-with-metadata-filter branch September 28, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants