FIX: Correctly save a ArgillaTrainer + TRL model with peft_config #3795
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you pass
peft_config
totrainer.update_config
, then it will currently still save the full (but broken) model with some LoRA (or other PEFT) parts interspersed that can't be loaded again. This is because theself._transformers_model
was saved, but that model was the original model (e.g. Llama 2 7b) and not the PEFT model, which is created internally in e.g. the SFTTrainer.In short, this now saves the actual model and tokenizer used by the underlying trainer, so that if that trainer make any other changes to the model, those changes will be saved too.
Type of change
How Has This Been Tested
Created a new test and verified that there's now
adapter_model.bin
andadapter_config.json
files after training.Checklist
CHANGELOG.md
file (See https://keepachangelog.com/)