Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quickstart.Dockerfile after updating Dockerfile #3793

Merged
merged 6 commits into from
Sep 20, 2023

Conversation

gabrielmbmb
Copy link
Member

Description

This PR updates the quickstart.Dockerfile so it's compatible with the updates done for the Dockerfile in #3221.

Also, the Dockerfile has been updated to create the virtualenv in a common path between the builder stage and the final stage, otherwise, Python binaries will throw this error:

bash: /home/worker/my-virtual-env/bin/uvicorn: cannot execute: required file not found

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

  • docker build . -t argilla/argilla-server:v1.17.0
  • docker run argilla/argilla-server:v1.17.0
  • docker build . --build-arg ARGILLA_VERSION=1.17.0 -f quickstart.Dockerfile -t argilla/argilla-quickstart:v1.17.0
  • docker run argilla/argilla-quickstart:v1.17.0

Checklist

  • I followed the style guidelines of this project
  • I did a self-review of my code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@gabrielmbmb gabrielmbmb added this to the v1.17.0 milestone Sep 20, 2023
@gabrielmbmb gabrielmbmb self-assigned this Sep 20, 2023
@github-actions
Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3793-ki24f765kq-no.a.run.app

Co-authored-by: Francisco Aranda <[email protected]>
@gabrielmbmb gabrielmbmb merged commit 5ff77fb into develop Sep 20, 2023
@gabrielmbmb gabrielmbmb deleted the fix/quickstart-image branch September 20, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants