Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SearchEngine had num index == num replicas #3736

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

gabrielmbmb
Copy link
Member

Description

When the instance of SearchEngine was created we were passing the value of the attribute settings.es_records_index_shards to both es_number_of_shards and es_number_of_replicas arguments. This PR fix that and now value of attribute settings.es_records_index_shards is passed to es_number_of_replicas argument.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

In a local development environment:

  • Run the Argilla server without the fix and create a FeedbackDataset. When calling GET localhost:9200/_cat/shards?v, two shards are listed for the dataset (one primary started and one replica unassigned)
  • Run the Argilla with the fix and create a FeedbackDataset. When calling GET localhost:9200/_cat/shards?v, only one primary shard is listed for the dataset

Checklist

  • I followed the style guidelines of this project
  • I did a self-review of my code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@gabrielmbmb gabrielmbmb added area: api Indicates that an issue or pull request is related to the Fast API server or REST endpoints bugfix labels Sep 8, 2023
@gabrielmbmb gabrielmbmb self-assigned this Sep 8, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3736-ki24f765kq-no.a.run.app

@gabrielmbmb gabrielmbmb merged commit 4a9ad03 into releases/1.15.1 Sep 8, 2023
@gabrielmbmb gabrielmbmb deleted the fix/search-engine-number-of-replicas branch September 8, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: api Indicates that an issue or pull request is related to the Fast API server or REST endpoints
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants