feat: add workspace_id param to GET /api/v1/me/datasets
#3727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
|
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3727-ki24f765kq-no.a.run.app |
gabrielmbmb
approved these changes
Sep 7, 2023
Co-authored-by: Gabriel Martín Blázquez <[email protected]>
frascuchon
reviewed
Sep 7, 2023
Comment on lines
+81
to
+85
| workspace = await WorkspaceFactory.create() | ||
| dataset = await DatasetFactory.create(workspace=workspace) | ||
| user = await UserFactory.create(role=role, workspaces=[dataset.workspace] if with_workspace else []) | ||
|
|
||
| another_workspace = await WorkspaceFactory.create() |
There was a problem hiding this comment.
(Just a comment) we should start thinking about a seed script to feed integration test data in a different way
There was a problem hiding this comment.
With "a different way" do you mean without using the factories? Ideally we can define a function on each test suite (we are already doing that in some places) to call a self function for e.g. create a dataset (with different args), to call that function instead of explicit calls to the factories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
workspace_idparam toGET /api/v1/me/datasetsso that the workspace filtering when listingFeedbackTaskdatasets is applied in the API-side, as well as making sure that no local filters are applied e.g.FeedbackDataset.list(workspace=...)Closes #3726
Type of change
How Has This Been Tested
GET /api/v1/me/datasetsusing theworkspace_idparam, including also the updated policies for non-owner userslist_datasetsin the Python SDK using theworkspace_idargFeedbackDataset.listin the Python client using theworkspaceargChecklist