feat: add datasets delete command
#3703
Conversation
gabrielmbmb
added
type: enhancement
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
|
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3703-ki24f765kq-no.a.run.app |
|
|
||
| try: | ||
| dataset.delete() | ||
| except RuntimeError as e: |
There was a problem hiding this comment.
Here we can also handle PermissionError which is raised by allow_for_roles decorator if the user doesn't have owner role
| return_value=remote_feedback_dataset, | ||
| ) | ||
|
|
||
| result = cli_runner.invoke(cli, "datasets --name my-dataset push-to-huggingface") |
There was a problem hiding this comment.
With the current approach for the CLI as datasets [NAME] [WORKSPACE] [CMD] [ARGS] shouldn't we make CMD show the --help by default? Or do we want it to fail if no args are provided? I guess it would depend on whether we have commands without args or not, right?
There was a problem hiding this comment.
I mean whether we should include no_args_is_help=True the the CMD e.g. push-to-huggingface
There was a problem hiding this comment.
ah, I see! I think it's better to not show by default the --help
Co-authored-by: Alvaro Bartolome <[email protected]>
…om/argilla-io/argilla into feature/cli-delete-dataset-command
Description
This PR adds a new command
datasets deletethat allows to deleteFeedbackDatasets. In addition, a custom callback has been added for the group of commandsdatasetsin which a--nameand a--workspacecan be provided to load aFeedbackDatasetthat will be used for an operation. Apart from that, thepush-to-hugginfacecommand has been updated to display an spinner.Closes #3691
Type of change
How Has This Been Tested
In a local development environment:
python -m argilla datasets --name feedback-dataset --workspace gabriel delete: deletes theFeedbackDatasetsuccessfully.Checklist
CHANGELOG.mdfile (See https://keepachangelog.com/)