Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add push-to-huggingface command #3685

Merged
merged 14 commits into from
Sep 1, 2023
Merged

feat: add push-to-huggingface command #3685

merged 14 commits into from
Sep 1, 2023

Conversation

alvarobartt
Copy link
Member

@alvarobartt alvarobartt commented Aug 31, 2023 •
edited
Loading

Description

This PR adds the datasets push-to-huggingface command to the Argilla CLI, to push a FeedbackDataset from Argilla into the HuggingFace Hub.

Closes #3670

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

  • Add unit tests for the datasets push-to-huggingface command

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@alvarobartt alvarobartt added type: enhancement Indicates new feature requests area: cli Indicates that an issue or pull request is related to the Command Line Interface (CLI) labels Aug 31, 2023
@alvarobartt alvarobartt added this to the v1.16.0 milestone Aug 31, 2023
@alvarobartt alvarobartt self-assigned this Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023 •
edited
Loading

Codecov Report

Patch coverage is 82.58% of modified lines.

Files Changed Coverage
src/argilla/client/feedback/dataset/base.py ø
src/argilla/client/feedback/dataset/local.py ø
src/argilla/client/feedback/dataset/mixins.py ø
.../argilla/client/feedback/dataset/remote/dataset.py ø
src/argilla/client/sdk/datasets/models.py ø
src/argilla/tasks/users/create.py ø
src/argilla/tasks/whoami/__main__.py ø
src/argilla/tasks/datasets/push.py 52.00%
src/argilla/tasks/users/list.py 78.37%
src/argilla/tasks/datasets/list.py 82.35%
... and 8 more

📢 Thoughts on this report? Let us know!.

@alvarobartt alvarobartt marked this pull request as ready for review August 31, 2023 13:59
@alvarobartt
fix(test): test_push_to_hf_missing_args
0f1936c 
Is failing the CI pipeline due to the formatting injected by `rich` and `typer`
gabrielmbmb
gabrielmbmb approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@gabrielmbmb gabrielmbmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some comments about the fixtures and adding the 🤗 emoji

@alvarobartt @gabrielmbmb
style: add :hugs: in push-to-hf message
143ea9d 
Co-authored-by: Gabriel Martín Blázquez <[email protected]>
@alvarobartt @gabrielmbmb
chore: remove explicit fixtures & __main__ block
5852aea 
Co-authored-by: Gabriel Martín Blázquez <[email protected]>
@github-actions
Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3685-ki24f765kq-no.a.run.app

@tomaarsen
Copy link
Contributor

Don't we use huggingface instead of hf elsewhere in the project?

tomaarsen
tomaarsen reviewed Sep 1, 2023
View reviewed changes
@alvarobartt
Copy link
Member Author

Don't we use huggingface instead of hf elsewhere in the project?

True, but for the command push-to-huggingface seems a bit long, anyway we can discuss this to see what's better between push-to-hub, push-to-hf or push-to-huggingface

@alvarobartt alvarobartt changed the title feat: add push-to-hf command feat: add push-to-huggingface command Sep 1, 2023
@alvarobartt alvarobartt merged commit c59bab7 into develop Sep 1, 2023
@alvarobartt alvarobartt deleted the feat/cli-push-to-hf branch September 1, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielmbmb gabrielmbmb gabrielmbmb approved these changes

@tomaarsen tomaarsen tomaarsen left review comments

Assignees

@alvarobartt alvarobartt

Labels
area: cli Indicates that an issue or pull request is related to the Command Line Interface (CLI) type: enhancement Indicates new feature requests
Projects
None yet
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add push to Hugging Face hub command python -m argilla datasets push-to-hf
3 participants
@alvarobartt @tomaarsen @gabrielmbmb