Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add users create command #3667

Merged
merged 10 commits into from
Aug 30, 2023
Merged

Conversation

gabrielmbmb
Copy link
Member

@gabrielmbmb gabrielmbmb commented Aug 30, 2023

Description

This PR adds users create command that allows to create an user calling the API and the logged user.

Closes #3588

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

I've added unit tests that covers the additions.

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
src/argilla/__main__.py 100.00%
src/argilla/client/users.py 100.00%
src/argilla/tasks/__init__.py 100.00%
src/argilla/tasks/rich.py 100.00%
src/argilla/tasks/users/__init__.py 100.00%
src/argilla/tasks/users/__main__.py 100.00%
src/argilla/tasks/users/create.py 100.00%

📢 Thoughts on this report? Let us know!.

@gabrielmbmb gabrielmbmb self-assigned this Aug 30, 2023
@gabrielmbmb gabrielmbmb added type: enhancement Indicates new feature requests client labels Aug 30, 2023
@gabrielmbmb gabrielmbmb added this to the v1.16.0 milestone Aug 30, 2023
@gabrielmbmb gabrielmbmb marked this pull request as ready for review August 30, 2023 13:08
Copy link
Member

@alvarobartt alvarobartt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Alvaro Bartolome <[email protected]>
@gabrielmbmb gabrielmbmb merged commit c84234d into develop Aug 30, 2023
@gabrielmbmb gabrielmbmb deleted the feature/cli-create-user-command branch August 30, 2023 14:04
@github-actions
Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3667-ki24f765kq-no.a.run.app

gabrielmbmb added a commit that referenced this pull request Sep 6, 2023
# Description

In #3667 a new command to create users was added. This command prints a
summary of the created user which includes a list of workspaces to which
the users belongs. Instead of the name of the workspaces, workspaces
classes were being printed. This PR fixes this.

**Type of change**

- [x] Bug fix (non-breaking change which fixes an issue)

**How Has This Been Tested**

In a local development environment:

- [x] `python -m argilla users create --username gabriel --role
annotator --workspace ws1 --workspace ws2`: prints `Workspaces: ws1,
ws2`

**Checklist**

- [x] I followed the style guidelines of this project
- [x] I did a self-review of my code
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK)
(see text above)
- [ ] I have added relevant notes to the `CHANGELOG.md` file (See
https://keepachangelog.com/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add create user command python -m argilla users create
2 participants