-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add users create
command
#3667
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
alvarobartt
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gabrielmbmb
commented
Aug 30, 2023
Co-authored-by: Alvaro Bartolome <[email protected]>
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3667-ki24f765kq-no.a.run.app |
8 tasks
gabrielmbmb
added a commit
that referenced
this pull request
Sep 6, 2023
# Description In #3667 a new command to create users was added. This command prints a summary of the created user which includes a list of workspaces to which the users belongs. Instead of the name of the workspaces, workspaces classes were being printed. This PR fixes this. **Type of change** - [x] Bug fix (non-breaking change which fixes an issue) **How Has This Been Tested** In a local development environment: - [x] `python -m argilla users create --username gabriel --role annotator --workspace ws1 --workspace ws2`: prints `Workspaces: ws1, ws2` **Checklist** - [x] I followed the style guidelines of this project - [x] I did a self-review of my code - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [ ] I have added relevant notes to the `CHANGELOG.md` file (See https://keepachangelog.com/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
users create
command that allows to create an user calling the API and the logged user.Closes #3588
Type of change
How Has This Been Tested
I've added unit tests that covers the additions.
Checklist
CHANGELOG.md
file (See https://keepachangelog.com/)