-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add RemoteFeedbackDataset.filter_by
and FilteredRemoteFeedbackDataset
#3610
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #3610 +/- ##
===========================================
+ Coverage 90.56% 90.79% +0.22%
===========================================
Files 264 267 +3
Lines 14188 14260 +72
===========================================
+ Hits 12850 12948 +98
+ Misses 1338 1312 -26
☔ View full report in Codecov by Sentry. |
Pending #3613 merge, so that we can directly include the |
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3610-ki24f765kq-no.a.run.app |
Co-authored-by: Gabriel Martin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's okay for me. Just one thing. Should we add some sections in docs apart from the Python client refs? Maybe we can refactor an existing tutorial applying filters and start using the filter_by
method.
@frascuchon I agree. I think every added functionality to the Python API should be represented in the docs and that this needs to be done before wrapping up the PR. I see there also does not seem any reference to the inner workings of the @alvarobartt Could you add:
I will add a work item about representing the change above and adding it to the |
Thanks! LFTM. Not sure if we want to change Feedback Dataset => |
Description
This PR adds a method named
filter_by
toRemoteFeedbackDataset
so as to be able to filter based on theresponse_status
of any given record in the dataset; as well as refactoring how theRemoteFeedbackDataset
is structured to detach the base functionality. Additionally,FilteredRemoteFeedbackDataset
has been created with certain constraints on what the users can do with it, while still being linked to Argilla, but using the specified filter.Type of change
How Has This Been Tested
remote.py
(now living underremote/dataset.py
)Checklist