fix: remove default from boolean values in argilla_template.md
#3499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmbmb
approved these changes
Aug 2, 2023
keithCuniah
pushed a commit
that referenced
this pull request
Aug 3, 2023
…3499) # Description This PR solves an on-going issue when default replacements are not properly applied in the Jinja2 template `argilla_template.md` for the HuggingFace dataset card generation. This was initially reported by @nataliaElv and even most of it was already solved at #3366, but the table was using the `default` statement from Jinja2 and it was not working as expected. **Type of change** - [X] Bug fix (non-breaking change which fixes an issue) **How Has This Been Tested** (Please describe the tests that you ran to verify your changes. And ideally, reference `tests`) - [X] Re-generated card including different `boolean` options to see whether those are properly included in the table as is, instead of being replaced by `True` by default **Checklist** - [ ] I added relevant documentation - [x] follows the style guidelines of this project - [x] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [x] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves an on-going issue when default replacements are not properly applied in the Jinja2 template
argilla_template.mdfor the HuggingFace dataset card generation.This was initially reported by @nataliaElv and even most of it was already solved at #3366, but the table was using the
defaultstatement from Jinja2 and it was not working as expected.Type of change
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests)booleanoptions to see whether those are properly included in the table as is, instead of being replaced byTrueby defaultChecklist