refactor: add ArgillaDatasetMixin and re-structure argilla.feedback.schemas
#3427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, I've also rewritten the docstrings to make those clearer and following a more standardized format
@davidberenstein1957 should have another look into this once he's back to add missing type-hints and refactor the unit tests for the unfication strategies, eventually to be refactored
10 tasks
alvarobartt
force-pushed
the
refactor/schemas-and-argilla-mixin
branch
from
afdbe77 to
a2e9134
Compare
gabrielmbmb
reviewed
Jul 24, 2023
Co-authored-by: Gabriel Martin <[email protected]>
leiyre
pushed a commit
that referenced
this pull request
Aug 1, 2023
…rgilla into feat/shortcuts-improvements * 'feat/shortcuts-improvements' of github.com:argilla-io/argilla: feat: update CLI to use async connection to DB (#3450) feat: add more value validations for rating questions (#3452) ci: selective `runs-on` value for tests execution (#3455) feat: update `package.yml` triggers (#3422) fix: uncancellable CI jobs (#3458) chore: Fix `ruff` line length (#3459) [pre-commit.ci] pre-commit autoupdate (#3449) improvement: Better efficiency of Weak Labels when vectors exist (#3444) refactor: add `ArgillaDatasetMixin` and re-structure `argilla.feedback.schemas` (#3427) chore: Set release version fix: add missing `suggestion_type_enum` values (#3445) [pre-commit.ci] pre-commit autoupdate (#3380) docs: fix username in HF Spaces docs (#3432)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR starts off with the refactoring effort to make sure that everything's more maintainable and scalable.
So on, this PR refactors the
argilla/feedback/schemas.pyto be split in different files in a more organised way asargilla/feedback/schemas/*.pyso that we havefields.py,questions.pyandrecords.pyto contain the mainpydantic.BaseModels for those. Also all the docstrings have been rewritten from scratch to be clearer and provide more information.Additionally, this PR also adds the
ArgillaDatasetMixinto detach the Argilla-related functionality from theFeedbackDatasetitself, as we recently did for the HuggingFace Hub integration (i.e. #3326)Type of change
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests)pydantic.BaseModelunderargilla/feedback/schemasChecklist