feat: reviewing user tasks cli #3188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmbmb
approved these changes
Jun 14, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## 3094-support-for-owner-and-workspace-admin-roles #3188 +/- ##
====================================================================================
- Coverage 90.93% 90.93% -0.01%
====================================================================================
Files 215 216 +1
Lines 11333 11354 +21
====================================================================================
+ Hits 10306 10325 +19
- Misses 1027 1029 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
10 tasks
alvarobartt
added a commit
that referenced
this pull request
Jun 22, 2023
# Description This PR creates the default user with `owner` role instead of `admin` in `release.Dockerfile`, so that the default user has all the required permissions matching the ones that the `admin` user had before, to avoid disruption. Also this PR creates an `owner` user besides the current `admin` and `annotator` users being created as part of the `quickstart.Dockerfile`. Reverts the PR at #3188 **Type of change** - [X] Refactor (change restructuring the codebase without changing functionality) **How Has This Been Tested** - [X] `docker build` both `quickstart.Dockerfile` and `release.Dockerfile` **Checklist** - [X] I added relevant documentation - [X] follows the style guidelines of this project - [X] I did a self-review of my code - [X] I made corresponding changes to the documentation - [X] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [X] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: Francisco Aranda <[email protected]>
davidberenstein1957
pushed a commit
that referenced
this pull request
Jun 26, 2023
# Description This PR creates the default user with `owner` role instead of `admin` in `release.Dockerfile`, so that the default user has all the required permissions matching the ones that the `admin` user had before, to avoid disruption. Also this PR creates an `owner` user besides the current `admin` and `annotator` users being created as part of the `quickstart.Dockerfile`. Reverts the PR at #3188 **Type of change** - [X] Refactor (change restructuring the codebase without changing functionality) **How Has This Been Tested** - [X] `docker build` both `quickstart.Dockerfile` and `release.Dockerfile` **Checklist** - [X] I added relevant documentation - [X] follows the style guidelines of this project - [X] I did a self-review of my code - [X] I made corresponding changes to the documentation - [X] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [X] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: Francisco Aranda <[email protected]>
davidberenstein1957
pushed a commit
that referenced
this pull request
Jun 26, 2023
# Description This PR creates the default user with `owner` role instead of `admin` in `release.Dockerfile`, so that the default user has all the required permissions matching the ones that the `admin` user had before, to avoid disruption. Also this PR creates an `owner` user besides the current `admin` and `annotator` users being created as part of the `quickstart.Dockerfile`. Reverts the PR at #3188 **Type of change** - [X] Refactor (change restructuring the codebase without changing functionality) **How Has This Been Tested** - [X] `docker build` both `quickstart.Dockerfile` and `release.Dockerfile` **Checklist** - [X] I added relevant documentation - [X] follows the style guidelines of this project - [X] I did a self-review of my code - [X] I made corresponding changes to the documentation - [X] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [X] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: Francisco Aranda <[email protected]>
davidberenstein1957
pushed a commit
that referenced
this pull request
Jun 26, 2023
This PR creates the default user with `owner` role instead of `admin` in `release.Dockerfile`, so that the default user has all the required permissions matching the ones that the `admin` user had before, to avoid disruption. Also this PR creates an `owner` user besides the current `admin` and `annotator` users being created as part of the `quickstart.Dockerfile`. Reverts the PR at #3188 **Type of change** - [X] Refactor (change restructuring the codebase without changing functionality) **How Has This Been Tested** - [X] `docker build` both `quickstart.Dockerfile` and `release.Dockerfile` **Checklist** - [X] I added relevant documentation - [X] follows the style guidelines of this project - [X] I did a self-review of my code - [X] I made corresponding changes to the documentation - [X] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [X] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: Francisco Aranda <[email protected]>
damianpumar
pushed a commit
that referenced
this pull request
Jun 27, 2023
# Description This PR creates the default user with `owner` role instead of `admin` in `release.Dockerfile`, so that the default user has all the required permissions matching the ones that the `admin` user had before, to avoid disruption. Also this PR creates an `owner` user besides the current `admin` and `annotator` users being created as part of the `quickstart.Dockerfile`. Reverts the PR at #3188 **Type of change** - [X] Refactor (change restructuring the codebase without changing functionality) **How Has This Been Tested** - [X] `docker build` both `quickstart.Dockerfile` and `release.Dockerfile` **Checklist** - [X] I added relevant documentation - [X] follows the style guidelines of this project - [X] I did a self-review of my code - [X] I made corresponding changes to the documentation - [X] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [X] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: Francisco Aranda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PRs mainly adds a new users task command to update an existing user (for now, only the user role can be used, but other fields like last name or even the password can be updated through this command)
Also, some refactors have been applied:
typertries to cast the role into a validUserRolevalue.adminrole, instead ofowner. This still works for environments with one single user and workspace.Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests)New tests have been added
Checklist