Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 FIX : Replaced Enum for string value in URLs for client API calls #3150

Merged

Conversation

Fancman
Copy link
Contributor

@Fancman Fancman commented Jun 11, 2023

Description

This PR fixes saving settings programmatically, with replacing ENUM for string value of task name in URLs which calls client.

Closes #3149

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Checklist

  • I have merged the original branch into my forked branch
  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@Fancman Fancman changed the title Replaced Enum for string value in URLs for client API calls 🐛 FIX : Replaced Enum for string value in URLs for client API calls Jun 11, 2023
@gabrielmbmb
Copy link
Member

Thanks for your PR @Fancman! Some of the unit tests are failing, but that's not your fault 😄

@gabrielmbmb gabrielmbmb merged commit 292d2e3 into argilla-io:develop Jun 13, 2023
@davidberenstein1957
Copy link
Member

davidberenstein1957 commented Jun 19, 2023

@Fancman do you want to participate in our contributor growers initiative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cannot save dataset settings programmatically
3 participants