Review docker and scripts #3133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The docker build context will be placed in docker folder - The unneeded scripts have been removed - The specific docker script have been moved into docker/scripts - The scripts used outside docker have been placed in scripts folder - Docs have been updated - The release.Dockerfile have been renamed to Dockerfile
frascuchon
commented
Jun 8, 2023
davidberenstein1957
approved these changes
Jun 8, 2023
davidberenstein1957
approved these changes
Jun 8, 2023
…-root' into review-docker-and-scripts
davidberenstein1957
merged commit ea5479b
into
feature/3052-refactor-to-avoid-having-too-many-files-in-root
davidberenstein1957
added a commit
that referenced
this pull request
Jun 26, 2023
The docker and script have been reviewed: - The docker build context will be placed in the docker folder, so we don't need to change anything inside the dockerfiles - The unneeded scripts have been removed - The specific docker script has been moved into docker/scripts - The scripts used outside docker have been placed in the scripts folder, otherwise, script execution may change. And not much sense to put them inside the docker folder since they are used outside docker images. - Docs have been updated - The `release.Dockerfile` has been renamed to `Dockerfile` (more standard way for the principal docker image) --------- Co-authored-by: davidberenstein1957 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The docker and script have been reviewed:
release.Dockerfilehas been renamed toDockerfile(more standard way for the principal docker image)