Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : front orm model instruction task #2680

Merged

Conversation

keithCuniah
Copy link
Contributor

@keithCuniah keithCuniah commented Apr 12, 2023

Description

Vuex orm model for instruction task and change route for instruction task page (domain/datasetId/annotation-mode)

image

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Part of the main branch #2615

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Feedback task (no impact in current task)

Checklist

  • I have merged the original branch into my forked branch
  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@keithCuniah keithCuniah requested a review from frascuchon April 14, 2023 08:55
@keithCuniah keithCuniah added the area: ui Indicates that an issue or pull request is related to the User Interface (UI) label Apr 14, 2023
@keithCuniah keithCuniah added this to the v1.7.0 milestone Apr 14, 2023
@keithCuniah keithCuniah marked this pull request as ready for review April 14, 2023 09:00
Copy link
Member

@frascuchon frascuchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds more things than the ORM model definition, right? Or there is another PR affecting the rest of the changes?

@keithCuniah keithCuniah merged commit e18b04c into feat/2615-instructions-task Apr 18, 2023
@keithCuniah keithCuniah deleted the feat/vuexorm-model-instruction-task branch April 18, 2023 11:17
@frascuchon frascuchon removed this from the v1.7.0 milestone May 10, 2023
@frascuchon frascuchon mentioned this pull request May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants