Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style update messages #2648

Merged
merged 44 commits into from
Apr 5, 2023
Merged

style update messages #2648

merged 44 commits into from
Apr 5, 2023

Conversation

keithCuniah
Copy link
Contributor

@keithCuniah keithCuniah commented Apr 4, 2023 •
edited
Loading

Description

Update messages

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

See #2626

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update
  • Style

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Test A

Checklist

  • I have merged the original branch into my forked branch
  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

keithCuniah and others added 30 commits January 30, 2023 16:10
feat(Client): remove on mouseleave event
26b8504
Merge branch 'develop' of https://github.com/recognai/rubrix into dev…
a5b48d9 
…elop
Merge branch 'develop' of https://github.com/recognai/rubrix into dev…
bdc3cb9 
…elop
Merge branch 'develop' of https://github.com/recognai/rubrix into dev…
e79eb6e 
…elop
Merge branch 'develop' of https://github.com/recognai/rubrix into dev…
6905376 
…elop
Merge branch 'develop' of https://github.com/recognai/rubrix into dev…
6a102ae 
…elop
Merge branch 'develop' of https://github.com/recognai/rubrix into dev…
e1b844c 
…elop
Merge branch 'develop' of https://github.com/recognai/rubrix into dev…
792fa5e 
…elop
Merge branch 'develop' of https://github.com/recognai/rubrix into dev…
1513d63 
…elop
Merge branch 'develop' of https://github.com/recognai/rubrix into dev…
90e98e0 
…elop
Merge branch 'develop' of https://github.com/recognai/rubrix into dev…
75366b6 
…elop
Merge branch 'develop' of https://github.com/recognai/rubrix into dev…
c117b3d 
…elop
Merge branch 'develop' of https://github.com/recognai/rubrix into dev…
da4026c 
…elop
Merge branch 'develop' of https://github.com/recognai/rubrix into dev…
0c5eef9 
…elop
Merge branch 'develop' of https://github.com/recognai/rubrix into dev…
2a0ff8e 
…elop
Merge branch 'develop' of https://github.com/recognai/rubrix into dev…
b2e20bb 
…elop
Merge branch 'develop' of https://github.com/recognai/rubrix into dev…
b47793e 
…elop
Merge branch 'develop' of https://github.com/recognai/rubrix into dev…
ca314e2 
…elop
Merge branch 'develop' of https://github.com/recognai/rubrix into dev…
5e905f6 
…elop
Merge branch 'develop' of https://github.com/recognai/rubrix into dev…
dc0f4d0 
…elop
Merge branch 'develop' of https://github.com/recognai/rubrix into dev…
b062d10 
…elop
Merge branch 'develop' of https://github.com/recognai/rubrix into dev…
84b383e 
…elop
Merge branch 'develop' of https://github.com/recognai/rubrix into dev…
f7ab48e 
…elop
update css && messages
a6c5a9e
toast on save rule in success and error
4369f63
@keithCuniah
update message
8976130
@keithCuniah
add toast on remove rule
bf978b0
@keithCuniah
Merge branch 'develop' into style/update-weeklabelling-styles
a8989bd
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
4c07e63 
updates:
- [github.com/Lucas-C/pre-commit-hooks: v1.4.2 → v1.5.1](Lucas-C/pre-commit-hooks@v1.4.2...v1.5.1)
- [github.com/psf/black: 23.1.0 → 23.3.0](psf/black@23.1.0...23.3.0)
- [github.com/charliermarsh/ruff-pre-commit: v0.0.259 → v0.0.260](astral-sh/ruff-pre-commit@v0.0.259...v0.0.260)
@keithCuniah
Merge branch 'develop' into style/update-weeklabelling-styles
998fe5d
keithCuniah and others added 5 commits April 4, 2023 13:14
@keithCuniah
update changelog
29dabda
@keithCuniah
update changelog
cdd3de8
@tomaarsen
[pre-commit.ci] pre-commit autoupdate (#2646)
5d7e274 
<!--pre-commit.ci start-->
updates:
- [github.com/Lucas-C/pre-commit-hooks: v1.4.2 →
v1.5.1](Lucas-C/pre-commit-hooks@v1.4.2...v1.5.1)
- [github.com/psf/black: 23.1.0 →
23.3.0](psf/black@23.1.0...23.3.0)
- [github.com/charliermarsh/ruff-pre-commit: v0.0.259 →
v0.0.260](astral-sh/ruff-pre-commit@v0.0.259...v0.0.260)
<!--pre-commit.ci end-->
@keithCuniah
update messages
63c99f3
@keithCuniah
Merge branch 'develop' into style/update-weeklabelling-styles
a8f61a3
@keithCuniah keithCuniah requested a review from frascuchon April 4, 2023 13:33
@keithCuniah keithCuniah marked this pull request as ready for review April 4, 2023 13:35
@keithCuniah keithCuniah added this to the v1.6.0 milestone Apr 4, 2023
@keithCuniah keithCuniah changed the base branch from develop to releases/1.6.0 April 4, 2023 13:41
frascuchon
frascuchon reviewed Apr 4, 2023
View reviewed changes
frascuchon
frascuchon reviewed Apr 4, 2023
View reviewed changes
frascuchon
frascuchon requested changes Apr 4, 2023
View reviewed changes
Copy link
Member

@frascuchon frascuchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review files and changelog please

@keithCuniah keithCuniah requested a review from frascuchon April 4, 2023 13:57
frascuchon
frascuchon reviewed Apr 4, 2023
View reviewed changes
@keithCuniah keithCuniah requested a review from frascuchon April 4, 2023 15:10
@keithCuniah keithCuniah requested a review from tomaarsen April 5, 2023 08:25
tomaarsen
tomaarsen approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@tomaarsen tomaarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect! Thanks

@frascuchon frascuchon merged commit d5f498d into releases/1.6.0 Apr 5, 2023
@frascuchon frascuchon deleted the style/update-weeklabelling-styles branch April 5, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliaElv nataliaElv nataliaElv left review comments

@frascuchon frascuchon frascuchon approved these changes

@tomaarsen tomaarsen tomaarsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@keithCuniah @frascuchon @tomaarsen @nataliaElv