Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to delete workspaces #3260

Closed
frascuchon opened this issue Jun 23, 2023 · 1 comment · Fixed by #3358
Closed

Allow to delete workspaces #3260

frascuchon opened this issue Jun 23, 2023 · 1 comment · Fixed by #3358
Assignees
@frascuchon @alvarobartt
Milestone
v1.13.0

Comments

@frascuchon
Copy link
Member

frascuchon commented Jun 23, 2023 •
edited
Loading

The backend will delete a workspace only if no datasets are created under it.
@nataliaElv nataliaElv moved this to Q3 2023 in 🚲 Argilla Roadmap Jul 3, 2023
@frascuchon frascuchon added this to the v1.13.0 milestone Jul 6, 2023
@frascuchon frascuchon changed the title Allow delete workspaces Allow to delete workspaces Jul 6, 2023
@frascuchon frascuchon modified the milestones: v1.13.0, v1.14.0 Jul 6, 2023
@frascuchon frascuchon linked a pull request Jul 7, 2023 that will close this issue
feat: Allow to delete workspaces #3358
Merged
14 tasks
@frascuchon frascuchon mentioned this issue Jul 7, 2023
Merged
14 tasks
@frascuchon frascuchon modified the milestones: v1.14.0, v1.13.0 Jul 7, 2023
@nataliaElv
Copy link
Member

Just adding a note here that this should be restricted to users with the owner role.

frascuchon added a commit that referenced this issue Jul 14, 2023
@frascuchon @alvarobartt
feat: Allow to delete workspaces (#3358)
c57cd04 
<!-- Thanks for your contribution! As part of our Community Growers
initiative 🌱, we're donating Justdiggit bunds in your name to reforest
sub-Saharan Africa. To claim your Community Growers certificate, please
contact David Berenstein in our Slack community or fill in this form
https://tally.so/r/n9XrxK once your PR has been merged. -->

# Description

This PR includes the missing functionality for deleting workspaces. A
workspace can be deleted only if no datasets are linked to it.
Otherwise, the operation will raise an error.


Closes #3260 

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Refactor (change restructuring the codebase without changing
functionality)
- [ ] Improvement (change adding some improvement to an existing
functionality)
- [ ] Documentation update



**Checklist**

- [ ] I added relevant documentation
- [x] follows the style guidelines of this project
- [x] I did a self-review of my code
- [ ] I made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK)
(see text above)
- [x] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)

---------

Co-authored-by: Alvaro Bartolome <[email protected]>
@frascuchon frascuchon mentioned this issue Jul 18, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frascuchon frascuchon

@alvarobartt alvarobartt

Labels
None yet
Projects
None yet
Milestone
v1.13.0
Development

Successfully merging a pull request may close this issue.

feat: Allow to delete workspaces argilla-io/argilla
3 participants
@frascuchon @alvarobartt @nataliaElv