-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update executor back to default of not bubbling errors to main flow #3410
Conversation
…tead set them as multierr prog Signed-off-by: Christopher Phillips <[email protected]>
Signed-off-by: Christopher Phillips <[email protected]>
I think we want to keep the executor behavior and instead change the This PR reverts the changes found here under |
…o return nil Signed-off-by: Christopher Phillips <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Description
The latest releases of syft saw a change where
err
was returned by theexecutor
causing the main control flow to exit on task failure. This PR reverts this change and instead writes the errors to a multi err value which sets prog warnings in the TUIFixes: NO BUG FILED
Bug fix (non-breaking change which fixes an issue)
Checklist:
Behavior on latest release:
Behavior on this PR showing warnings in cataloged contents, but still produces an SBOM