simulator/encrypted-dns: new encrypted DNS module #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Covers: #19 Wanted to run this by you guys to see if you're happy with the approach. DoH - JSON where possible, wire DNS protocol where needed. |
DoH and DoT. TODO: DNSCrypt
kmroz
force-pushed
the
issues/19-encrypted_dns
branch
2 times, most recently
from
7b29055 to
6eee168
Compare
BindAddr, if set by the user via -iface, will be used in the various dialers. Simulation HostMsg() will display the protocol used in the simulation run (ie. DoH, DoT, DNSCrypt).
kmroz
force-pushed
the
issues/19-encrypted_dns
branch
from
6eee168 to
18139ae
Compare
Address comments in code review, namely: - servers pulled from open-wisdom - no protocol specified, run all protocols against a random set of servers Further enhancements and fixes
|
Before we push this through, I'd like to do a test run on Windows (today). Also, for dnscrypt, I've not had luck using TCP as a communication protocol. Not sure if this is to do with the servers I've thus far tested against, or the backend lib that's pulled together from a couple of different sources. UDP works well. I'll open a ticket for myself to investigate further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DoH and DoT.
TODO: DNSCrypt