Learn2code | Review of the love2code configs #164
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkgr
requested changes
Feb 14, 2025
Comment on lines
116
to
124
| return AdamWConfig( | ||
| lr=4e-4, | ||
| weight_decay=0.1, | ||
| betas=(0.9, 0.95), | ||
| group_overrides=[ | ||
| OptimGroupOverride(params=["embeddings.weight"], opts=dict(weight_decay=0.0)) | ||
| ], | ||
| fused=True, | ||
| ) |
There was a problem hiding this comment.
Does Granite have any guidelines here?
LRs it still a black art. 7B was fine with up to 12e-4. So I think you can go higher here. Let's do 12e-4 for this one as well. You're going to train these to the end before thinking about the results, right?
There was a problem hiding this comment.
For the phase-1 pretraining, the learning rate follows a cosine schedule starting from 3 × 10−4 which decays to 3× 10−5 with an initial linear warmup step of 2k iterations.
From Granite. So I guess we jut replicate?
There was a problem hiding this comment.
Okay, switched to 12e-4, linearly decaying to 12e-5, with 2k steps of warmup.
|
Actually, the rest of the script was just boiler plate, so I guess I'm done after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dirk, help?