Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AD5X & SUNLU filaments for Flashforge + fixes & updates #8573

Merged
merged 3 commits into from
Mar 1, 2025

Conversation

RikshaDriver
Copy link
Contributor

  • Added AD5X
  • Added SUNLU filaments for AD5 and AD3 series
  • Updated SUNLU filament & setting IDs for BBL
  • Updated SUNLU parameters in OrcaLibrary
  • Fixes & enhancements for Flashforge profiles

@RikshaDriver
Copy link
Contributor Author

RikshaDriver commented Feb 26, 2025

@SoftFever this is a cut-down version of PR #8461 which was reverted

I have not added the G4P and associated problematic profiles nor the Flashforge branded filaments which had a number of nested inheritance issues

- Added AD5X
- Added SUNLU filaments for AD5 and AD3 series
- Updated SUNLU filament & setting IDs for BBL
- Updated SUNLU parameters in OrcaLibrary
- Fixes & enhancements for Flashforge profiles
@RikshaDriver
Copy link
Contributor Author

RikshaDriver commented Feb 27, 2025

@SoftFever Doesn't look like this got merged properly

@SoftFever
Copy link
Owner

Hi @RikshaDriver,
Ahh, it hasn't been merged yet.
I plan to give it a test before merging, but I'm fully occupied with my day job and family errands today.
Meanwhile, I would appreciate it if you could do some due diligence testing—just in case, even though you've probably already done a lot.
Let me know if you have any questions!

@RikshaDriver
Copy link
Contributor Author

Hi @SoftFever I've done testing prior to upload. This commit avoids all the problematic profiles. I will defer that to @Bai825 @linnaiyuan @FlashforgeOfficial and others from Flashforge to push upstream from Orca-Flashforge fork.

@RikshaDriver
Copy link
Contributor Author

Also I noticed you've set max volumetric flow for SUNLU filaments in OrcaLibrary to 12.

Is this deliberate as most filaments can easily go up to 16, 24 or higher? Happy to push the correct max values if required.

BTW, thanks for your hard work and dedication on this project!

@atanisoft
Copy link

@RikshaDriver I'm testing your original PR in the beta and seeing some odd behavior related to the IFS, it seems to be disabled by default even if the sliced model uses more than one filament. Have you observed this in your tests? I'd expect this to "just work" but perhaps I'm missing some option in Orca?

@RikshaDriver
Copy link
Contributor Author

RikshaDriver commented Mar 1, 2025

@RikshaDriver I'm testing your original PR in the beta and seeing some odd behavior related to the IFS, it seems to be disabled by default even if the sliced model uses more than one filament. Have you observed this in your tests? I'd expect this to "just work" but perhaps I'm missing some option in Orca?

I don't have the AD5X as yet, but the machine code is a mirror of Orca-Flashforge repo. All I have done for AD5X is added the machine and added it to the Generic Filaments.

@SoftFever
Copy link
Owner

Also I noticed you've set max volumetric flow for SUNLU filaments in OrcaLibrary to 12.

Is this deliberate as most filaments can easily go up to 16, 24 or higher? Happy to push the correct max values if required.

BTW, thanks for your hard work and dedication on this project!

thanks for the kind words, and thank you for your contribution too!

Regards the max volumetric flow, yes, it's deliberate to set 12 as this is supposed to be generic profile all machine. As not all machines has high flow hotend

@SoftFever
Copy link
Owner

Did some primary test, looks good.
Merged

@SoftFever SoftFever merged commit 1865206 into SoftFever:main Mar 1, 2025
1 check passed
@RikshaDriver
Copy link
Contributor Author

Also I noticed you've set max volumetric flow for SUNLU filaments in OrcaLibrary to 12.
Is this deliberate as most filaments can easily go up to 16, 24 or higher? Happy to push the correct max values if required.
BTW, thanks for your hard work and dedication on this project!

thanks for the kind words, and thank you for your contribution too!

Regards the max volumetric flow, yes, it's deliberate to set 12 as this is supposed to be generic profile all machine. As not all machines has high flow hotend

I suspected that was the case. With the slower machines, wouldn't the machine profile speed parameters likely limit the max flow regardless?

@SoftFever
Copy link
Owner

Also I noticed you've set max volumetric flow for SUNLU filaments in OrcaLibrary to 12.
Is this deliberate as most filaments can easily go up to 16, 24 or higher? Happy to push the correct max values if required.
BTW, thanks for your hard work and dedication on this project!

thanks for the kind words, and thank you for your contribution too!
Regards the max volumetric flow, yes, it's deliberate to set 12 as this is supposed to be generic profile all machine. As not all machines has high flow hotend

I suspected that was the case. With the slower machines, wouldn't the machine profile speed parameters likely limit the max flow regardless?

It's not necessary true. You can have a slow machine with big nozzle(but still low flowrate hotend) for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants