Fix calls to Page::new_optgroup() #8569
Conversation
|
instead adding parentheses can you remove translation from icon names. i assume its not required to use translation on icon names. @Noisyfox what's your opinion on this. |
|
The icon names are not translated, the |
| Line line = Line{ L("Fan speed-up time"), optgroup->get_option("fan_speedup_time").opt.tooltip }; | ||
| line.append_option(optgroup->get_option("fan_speedup_time")); | ||
| line.append_option(optgroup->get_option("fan_speedup_overhangs")); | ||
| optgroup->append_line(line); | ||
| optgroup->append_single_option_line("fan_kickstart"); | ||
|
|
||
| optgroup = page->new_optgroup(L("Extruder Clearance"), "param_extruder_clearence"); | ||
| optgroup = page->new_optgroup(L("Extruder Clearance"), L"param_extruder_clearence"); |
There was a problem hiding this comment.
I believe this should be L"param_extruder_clearance", but I am not sure where else this name should be fixed.
|
i was about to send this commit with removing all L on icon names and its already works as normal, you can see my comment in in here #7602 (comment) . just waiting respond for correct way |
|
If the string conversion happens at compile time, I agree with you that all the |
|
Have you seen my comment about the |
|
its a typo mistake, if you want to fix that you should also fix icon name on images folder |
|
icon visible in here |
Description
Fix the second param on calls to
Page::new_optgroup(), which should be anL""