Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Internal Bridge angle override #7908

Merged
merged 8 commits into from
Feb 9, 2025

Conversation

igiannakas
Copy link
Contributor

@igiannakas igiannakas commented Jan 3, 2025

Description

Enable overriding of the auto calculated internal bridge angle for cases where the automated algorithm fails to produce adequate bridging results.

Set to 0 (default) to disable (retain the automated calculation).

Fixes #2186

Screenshots/Recordings/Graphs

Default
image

Override:
image

Tests

  1. Tested with 0 value - works as expected. Automatically calculated bridge angle used
  2. Tested with any > 0 set value. Works as expected
  3. Used modifier on the object to set override. Works, but only if the entire bridging layer is covered by the modifier.

@Noisyfox would welcome your thoughts please on point 3. When placing a modifier it segments the region correctly but it ignores the angle provided. Unfortunately I am not very familiar with this (quite complex) code so will end up breaking something if I interfere more :) any pointers on where to look for this would be greatly appreciated :)

Copy link

@laukejas laukejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it seems to be working without any issues.

@MxBrnr
Copy link

MxBrnr commented Feb 1, 2025

How close is this to finally being merged? Desperately waiting for them to hit the nightly build.

@igiannakas
Copy link
Contributor Author

You can use them today if you want from the build artefacts here, or if you want a more complete build including some more PRs that are currently in review feel free to use my dev branch temporarily till the reviews are done.

https://github.com/igiannakas/OrcaSlicer/actions/runs/13091477443

@SoftFever
Copy link
Owner

Thank you @igiannakas
I'm not totally clear or convinced the use case of manually adjusting the internal bridge's direction.
But we can give it a try.

@SoftFever SoftFever merged commit 229a826 into SoftFever:main Feb 9, 2025
16 checks passed
@igiannakas
Copy link
Contributor Author

Me neither / typically the auto direction works very well but from the raised issues it appears that there are some niche cases where it may be needed. Let’s see :)

@igiannakas igiannakas deleted the Internal-bridge-angle-override branch February 9, 2025 14:20
@Ro3Deee
Copy link

Ro3Deee commented Feb 10, 2025

Yes there are some cases, for example when the bridging area is curved, moon like ☪️ . Thank you

@igiannakas
Copy link
Contributor Author

Give the latest nightly a go and offer feedback if this addresses your issue :)

@Pykkles
Copy link

Pykkles commented Feb 11, 2025

@SoftFever @igiannakas I've just been having a problem with this and looked in to whether this had already been reported - what timing!

Here's an example of where manual control would help me. You can see that on the left side of the image, the bridging direction makes sense but on the bottom it's pretty suboptimal. I could overcome this with more sparse infill underneath but this part doesn't need any real strength in the Z direction so being able to manually choose the direction should help me save some print time and material.

I'll get the latest nightly and give it a go.

SparseInfillDirection
Note: I've not updated for a while - screenshot is from 2.1.1

@igiannakas
Copy link
Contributor Author

Yes indeed the latest nightly should address this case. Please let me know if it doesn’t work…

@Pykkles
Copy link

Pykkles commented Feb 11, 2025

It's done exactly what I needed it to. Thanks!

As you said, using a modifier doesn't work on a part of the infill but it does cause some additional internal solid infill on the layer below. I doubt this is an issue but thought I'd flag it as you called out modifiers specifically in your earlier post.
image

I don't know what the normal process is for warning users about other settings but I found that I also needed to change solid infill direction for the setup I have. This model needs the internal bridge infill to be 45 degrees which is the same as my normal solid infill direction so I had to change that to 135 to effectively keep rotate solid infill direction.

Pedantry: you've got a leading space on the last line of the tooltip (PrintConfig.cpp:965) ...for zero angle.\n\n It is recommended...

@igiannakas
Copy link
Contributor Author

Indeed I couldn’t get the modifier to work on a part covered surface as the bridge polygons are generated in one go and I don’t believe respect part covered modifiers. I may be wrong but for now it will do…The alternative would be to completely block it from modifiers but then part of the usefulness would be gone so kept it even with a partially functioning modifier capability.

I’ll correct the typo in the other PR I currently have open for bridging to avoid creating more work for soft fever

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants