Enhancement: Enable separate internal bridge fan speed control #7906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnal-bridge-fan-control
|
How close is this to finally being merged? Desperately waiting for them to hit the nightly build. |
|
Replied to your other post - for now go ahead and use the dev build that has both of them plus the other bridging enhancements I’ve raised a PR for today. Don’t forget to switch back when these are reviewed and merged. The review process takes time as it’s all done on everyone’s free time :) |
|
No worries :)😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables independent fan speed control for internal bridges.
When set to -1 (default value), the existing behaviour is retained, which enables backwards compatibility against user's existing filament profiles.
When set to any other value, that fan speed % is used when printing internal bridges.
Please note, when printing internal bridges, the fan speed is statically set to the % specified by the user and is not clamped down by the minimum fan speed nor adjusted upwards if layer time is not met.
The above point is deliberate, as typically internal bridges are printed slowly, and are therefore the toolhead is "dumping" a lot of part cooling air on the part, which may result in overcooling the lower layers. Therefore, allowing the user to set a lower fan speed than the minimum may result in reduced warping when printing cooling sensitive materials, like ABS/ASA etc.
Have also updated some of the tooltips and labels surrounding the fan speed features to make them more explanatory.
Screenshots/Recordings/Graphs
Fan speed set:
Notice the "blue" fan speed (20%) for the internal bridge. Also notice that external overhang perimeters are unaffected (the "red" fan speed).
Compatibility with existing profiles:
Tests
Regression test: Set to -1 - current behaviour is retained
Feature tests:
Set to any arbitrary % - internal bridge speeds are set to that %. External bridge speeds and overhang speeds are unaffected by this change.
Fixes #2186