Fan mover: Ignore non-part cooling fans (SoftFever/OrcaSlicer#7171) #7193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the first half. The cooling layer is a different issue and will be addressed in its own PR. |
SoftFever
reviewed
Oct 25, 2024
|
@SoftFever I know this didn't quite make it into 2.2.0 , and while I technically have permission to approve it, I feel like I probably shouldn't :). It does appear to be OK to me though. |
Noisyfox
force-pushed
the
bugfox/fan-mover-m106
branch
from
c42d3d9 to
fd56377
Compare
SoftFever
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7171
Fna mover now manipulate part cooling fans only and ignore all other fans (which is what it's designed for).