Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements & fixes for Ender-3 V3 KE #5743

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Minor improvements & fixes for Ender-3 V3 KE #5743

merged 2 commits into from
Jun 18, 2024

Conversation

cochcoder
Copy link
Contributor

As mentioned with this comment

@Orel-A
Copy link

Orel-A commented Jun 17, 2024

The machine_pause_gcode should remain the same, only change_filament_gcode should be changed to M600.
The M600 gcode is a pause and a retraction of filament:
image

@cochcoder
Copy link
Contributor Author

The machine_pause_gcode should remain the same, only change_filament_gcode should be changed to M600. The M600 gcode is a pause and a retraction of filament: image

Thanks for pointing this out! It has been reverted.

Copy link

@Orel-A Orel-A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks

@SoftFever SoftFever merged commit 1678127 into SoftFever:main Jun 18, 2024
1 check passed
@cochcoder cochcoder deleted the ender3-v3-ke-3 branch June 18, 2024 14:29
@Orel-A
Copy link

Orel-A commented Jun 21, 2024

@cochcoder
There is a problem with this line in Machine End G-code:
G1 X5 Y5 F3000 ;Wipe out
It caused me today an out of bound error. The print hanged without finishing and stuck there.
We should rethink these 3 lines:

G1 E-2 F2700 ;Retract a bit
G1 E-2 Z0.2 F2400 ;Retract and raise Z
G1 X5 Y5 F3000 ;Wipe out

What do you think?

@cochcoder
Copy link
Contributor Author

@cochcoder There is a problem with this line in Machine End G-code: G1 X5 Y5 F3000 ;Wipe out It caused me today an out of bound error. The print hanged without finishing and stuck there. We should rethink these 3 lines:

G1 E-2 F2700 ;Retract a bit
G1 E-2 Z0.2 F2400 ;Retract and raise Z
G1 X5 Y5 F3000 ;Wipe out

What do you think?

How tall was the print? I think it went up too high in the end due to not checking its current height.

@Orel-A
Copy link

Orel-A commented Jun 23, 2024

It went out of bound on the X-axis.

image

@cochcoder
Copy link
Contributor Author

Can you send me tbd project file?

@Orel-A
Copy link

Orel-A commented Jun 23, 2024

The model file is under copyright license.
https://www.crealitycloud.com/model-detail/659aa4ff2063ad89b7be1e6a
The part being printed is the MOONLEFTUP.stl file.
Downsized to 80% (aside from the height) which is 216mm x 216mm x 30mm.

@cochcoder
Copy link
Contributor Author

Are you able to recreate the error by using a small piece of a cube? If so can you upload that project file?

@Orel-A
Copy link

Orel-A commented Jun 23, 2024

Here:
Cube Error.zip
Edit: Accidentally opened it in BambuStudio, download it now again.

image

@Orel-A
Copy link

Orel-A commented Jun 24, 2024

Any conclusions?

@Orel-A
Copy link

Orel-A commented Jun 30, 2024

@cochcoder
I made some changes to the Machine End G-code that will also allow us to increase the printable height. I also removed the problematic "Wipe out" gcode line.
The [stepper_z] section in printer.cfg has a position_max of 246mm.

New code:

G92 E0 ;Reset Extruder
G1 E-1.2 Z{max_layer_z + 0.5} F1800 ;Retract and raise Z
{if max_layer_z < 50}
G1 Z{max_layer_z + 25} F900 ;Raise Z more
{endif}

G1 X2 Y218 F3000 ;Present print
M106 S0 ;Turn-off fan
M104 S0 ;Turn-off hotend
M140 S0 ;Turn-off bed

M84 X Y E ;Disable all steppers but Z

JSON:

"printable_height": "245"
"retract_lift_below": ["245"]
"machine_end_gcode": "G92 E0 ;Reset Extruder\nG1 E-1.2 Z{max_layer_z + 0.5} F1800 ;Retract and raise Z\n{if max_layer_z < 50}\nG1 Z{max_layer_z + 25} F900 ;Raise Z more\n{endif}\n\nG1 X2 Y218 F3000 ;Present print\nM106 S0 ;Turn-off fan\nM104 S0 ;Turn-off hotend\nM140 S0 ;Turn-off bed\n\nM84 X Y E ;Disable all steppers but Z"

@cochcoder
Copy link
Contributor Author

@cochcoder I made some changes to the Machine End G-code that will also allow us to increase the printable height. I also removed the problematic "Wipe out" gcode line. The [stepper_z] section in printer.cfg has a position_max of 246mm.

New code:

G92 E0 ;Reset Extruder
G1 E-1.2 Z{max_layer_z + 0.5} F1800 ;Retract and raise Z
{if max_layer_z < 50}
G1 Z{max_layer_z + 25} F900 ;Raise Z more
{endif}

G1 X2 Y218 F3000 ;Present print
M106 S0 ;Turn-off fan
M104 S0 ;Turn-off hotend
M140 S0 ;Turn-off bed

M84 X Y E ;Disable all steppers but Z

JSON:

"printable_height": "245"
"retract_lift_below": ["245"]
"machine_end_gcode": "G92 E0 ;Reset Extruder\nG1 E-1.2 Z{max_layer_z + 0.5} F1800 ;Retract and raise Z\n{if max_layer_z < 50}\nG1 Z{max_layer_z + 25} F900 ;Raise Z more\n{endif}\n\nG1 X2 Y218 F3000 ;Present print\nM106 S0 ;Turn-off fan\nM104 S0 ;Turn-off hotend\nM140 S0 ;Turn-off bed\n\nM84 X Y E ;Disable all steppers but Z"

Sorry for taking so long to reply, I'll include the changes that you have, but I was thinking of adding a variable so that the wipe doesn't go over the max.

What do you think about having the printer only check if it can go up 25mm rather than 50mm? This would mean that there would no longer be a 25mm gap from the print head and the top of the printer at the end of each print.

@cochcoder
Copy link
Contributor Author

Is there a noticeable difference when the wipe gcode is removed?

@Orel-A
Copy link

Orel-A commented Jun 30, 2024

It's useless since it's wiping on air, there is a 0.2mm gap. So basically it doesn't do anything.

@cochcoder
Copy link
Contributor Author

@Orel-A
I've included the changes in a per, except for "retract_lift_below": ["245"], as this has to do with z-hops.

Before I mark it as ready to merge, can you have it go up to 245 on the z axis and make sure that there are no issues with that change? I am weary about this change as it is above the build volume given by Creality.

@Orel-A
Copy link

Orel-A commented Jul 1, 2024

Before I mark it as ready to merge, can you have it go up to 245 on the z axis and make sure that there are no issues with that change? I am weary about this change as it is above the build volume given by Creality.

There are no issues because the previous Machine End G-code had a 5mm Z-axis lift at the end of each print, so 240 + 5 = 245mm.
And I had run a few prints in the past that reached this height by removing the 5mm lift.
I also confirmed it just now by running G1 Z245. It's working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants