-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build on systems with libwebkit2gtk-4.1 #5135
Conversation
I tried running the AppImage from this PR on Fedora 40 and get the error: libwebkit2gtk-4.0.so.37: cannot open shared object file: No such file or directory The default lib seems to be webkitgtk6.0 but webkit2gtk4.0 can still be installed |
Purpose of this PR is to make OrcaSlicer compile on such systems. Contents and behavior of AppImage is not changed here. |
Same for me on kubuntu 24.04. What is surprising is that the appimage doesn't work as well... I thought that Appimages were created to avoid dependancies problems (all are built in the appimage package, like snap or flatpack... but I might be wrong). |
This PR only fixes compilation issue. For the AppImage fixes please check test build from #4616. #4616 (comment) |
@buzzhuzz Anyway, please refer to #5184, for changes related to wxWidgets; let's submit PRs there.: https://github.com/SoftFever/Orca-deps-wxWidgets |
Majority of that patch is configure script re-generated by autotools due to updated configure.am I'll open PR fo Orca-deps-wxWidgets first. |
Linux distros started removing libwebkit2gtk-4.0 libriry from their repos. Ubuntu Noble (24.04) is one of them. Modify debian/ubuntu deps to install libwebkit2gtk-4.1 if no libwebkit2gtk-4.0 available
57d2bd3
to
6658d7d
Compare
Thanks.
I suggest we don't include these changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you!
Description
Linux distros started removing libwebkit2gtk-4.0 library from their repos. Ubuntu Noble (24.04) is one of them.
Modify Linux deps script to check which version of libwebkit2gtk is available.
This change addresses #5007
Requires SoftFever/Orca-deps-wxWidgets#1 to be integrated first.
Tests
Build on Ubuntu 24.04 Beta
Build on Ubuntu 20.04 (through github actions)