dev-cmd: add brew verify #19217
Merged
dev-cmd: add brew verify #19217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a direct copy of `trailofbits/homebrew-brew-verify`, but in the `DevCmd` namespace instead. Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
dduugg
previously requested changes
Feb 3, 2025
There was a problem hiding this comment.
Looks good! Some very minor suggestions, but please add tests. (Check out https://github.com/Homebrew/brew/tree/master/Library/Homebrew/test/cmd and https://github.com/Homebrew/brew/tree/master/Library/Homebrew/test/dev-cmd for common patterns.)
Co-authored-by: Douglas Eichelberger <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
|
Thanks! I'll add some tests in a bit! |
MikeMcQuaid
approved these changes
Feb 3, 2025
dduugg
reviewed
Feb 3, 2025
Co-authored-by: Douglas Eichelberger <[email protected]>
woodruffw
force-pushed
the
ww/brew-verify
branch
from
ccd3278 to
b35cb75
Compare
Signed-off-by: William Woodruff <[email protected]>
|
I've added a basic "behaves like" test similar to the other dev-cmd specs. I'm not sure about how best to test this command more deeply, though -- we test the underlying API it calls pretty extensively in the attestations spec, but doing so requires a lot of extensive mocking (since we shell out to |
MikeMcQuaid
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?This is a direct copy of
trailofbits/homebrew-brew-verify,but in the
DevCmdnamespace instead.Signed-off-by: William Woodruff [email protected]