Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Demo site]When I use Edge's webpage translation, the webpage will use the translated text. #336

Closed
suq-weer opened this issue Sep 28, 2024 · 2 comments · Fixed by #380
Closed

[Demo site]When I use Edge's webpage translation, the webpage will use the translated text. #336

suq-weer opened this issue Sep 28, 2024 · 2 comments · Fixed by #380
Labels
bug Something isn't working good first issue Good for newcomers up for grabs Looking for new contributors

Comments

@suq-weer
Copy link

Describe the bug
When Edge translates the word 'true' in this webpage to '真' in Chinese, it will use this text.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the website.
  2. Click on 'Translate' in Edge.
  3. You can see this:

Translated text

  1. The generated website address will look like this (This is just a part) :
https://readme-typing-svg.demolab.com? (...) &center=%E7%9C%9F&vCenter=%E5%81%87&repeat=%E7%9C%9F&random=%E7%9C%9F& (...)

Smartphone:

  • Device: Mi 10 Lite Zoom
  • OS: MIUI 13.0.7
  • Edge 128.0.2739.82
@suq-weer suq-weer added the bug Something isn't working label Sep 28, 2024
@DenverCoder1 DenverCoder1 added good first issue Good for newcomers up for grabs Looking for new contributors labels Sep 29, 2024
@jatin-CodeCrafter
Copy link

Possible Workarounds:
Check if the translation can be manually adjusted or disabled for specific terms.

whiteSHADOW1234 added a commit to whiteSHADOW1234/readme-typing-svg that referenced this issue Feb 7, 2025
@whiteSHADOW1234
Fix issue DenverCoder1#336: Prevent Edge's translation from altering …
4c8e9e1 
…text by disabling translation on key elements
@whiteSHADOW1234 whiteSHADOW1234 mentioned this issue Feb 7, 2025
Merged
2 tasks
@whiteSHADOW1234
Copy link
Contributor

I have submitted a pull request (#380) to address this issue and am willing to be assigned to it. Please feel free to review the changes and let me know if any further modifications are needed.

DenverCoder1 pushed a commit that referenced this issue Feb 11, 2025
@whiteSHADOW1234
fix: prevent translation from breaking elements (#380)
30383df 
* Fix issue #336: Prevent Edge's translation from altering text by disabling translation on key elements

* fix: Use value attributes for option tags instead of disabling translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers up for grabs Looking for new contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: disable translation on key elements whiteSHADOW1234/readme-typing-svg
4 participants
@DenverCoder1 @suq-weer @whiteSHADOW1234 @jatin-CodeCrafter