-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Interactive Commands #72
base: main
Are you sure you want to change the base?
Conversation
Need to work on how interactive mode is handled when the tab or window focus is changed and then back to the active window/tab, some odd output going on. |
…to feat/backspace-moving-cursor
Working on input tracking for interactive mode, will track the number of keystroke & on carriage return (enter) we will clear the tracking. This will allow us to prevent the backspace, or cursor movement for interactive mode trying to go beyond where the input should let it. Tested in a branch merged with #70 and worked well so far. Still to fix:
|
20d1fbb
to
2022198
Compare
Have added an intercept of the bell command at the screen level which I am hopeful will avoid having to emulate too much of the readline for interactive commands in our multiplexer. |
…to feat/backspace-moving-cursor # Conflicts: # src/Prompt/Dashboard.php
The addition of the handling the bell sequent, as mentioned yesterday, actually does handle the issues caused by the command running in the Will just add tests & is ready to merge, will fix interactivity. I also want to look into adding a |
This pull request fixes the issues with interactive commands like Tinker by handling & removing the alert (BEL) sequence and temporarily playing the alert sound, which was getting added to the buffer and causing rendering & repetition of the alert sound issues.
TODO
fixes #54
#70 should be merged first, the rendering issues are dependant on the behavioural changes in that PR.