Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of minimal runtime images #5366

Open
1 task done
cazlo opened this issue Feb 27, 2025 · 1 comment · May be fixed by #5367
Open
1 task done

Addition of minimal runtime images #5366

cazlo opened this issue Feb 27, 2025 · 1 comment · May be fixed by #5367
Labels
feature New functionality/enhancement security

Comments

@cazlo
Copy link

cazlo commented Feb 27, 2025

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Describe the user story

As a security focused SRE, I want as few dependencies installed on my OCI container images as possible, so that I may simplify and automate vulnerability management as much as possible, and remove as many attack vectors from the system as possible. I find that sometimes I am getting pinged on vuln scans for the atlantis image for versions of terraform or tofu which I am not using.

I also want the business maintaining artifact storage for these images to have as low overhead as possible, so they may throw money at me instead.

Finally, I want Atlantis system rotation events (e.g. swapping nodes because I am updating a node group in k8s), to be as fast as possible, so that business services which rely on this deployment mechanism have as low downtime as possible.

Describe the solution you'd like

I like the current alpine images as a base. I recommend providing 2 alternate images which are very similar:

  • ghcr.io/runatlantis/atlantis:v0.33-alpine-slim-terraform - only would have /usr/local/bin/terraform which is version $DEFAULT_TERRAFORM_VERSION
  • ghcr.io/runatlantis/atlantis:v0.33-alpine-slim-tofu - only would have /usr/local/bin/tofu which is version $DEFAULT_OPENTOFU_VERSION

Describe the drawbacks of your solution

  • More ongoing engineer time cost for runatlantis maintainers to maintain more images.
  • Duplication of code risk in Dockerfile runtime stages

Describe alternatives you've considered

The build is Apache 2, so I can fork it and change it to meet my purpose without much worry relatively easy. However it would be a bummer if many (potentially thousands given star count) engineers ended up doing this as opposed to having a single source of truth for the minimal build.

I recommend only to support alpine for this context, because users seeking very minimal builds are more likely to use this compared to debian. This should mitigate the code duplication risk described earlier, there will only be code dupe for alpine but not for the debian images.

@cazlo cazlo added the feature New functionality/enhancement label Feb 27, 2025
@dosubot dosubot bot added the security label Feb 27, 2025
@cazlo cazlo linked a pull request Feb 27, 2025 that will close this issue
@X-Guardian
Copy link
Contributor

@cazlo, you don't need to fork the repo, just create your own custom docker image FROM the current Atlantis image. You can then customise it as you want, and there is no need for us to maintain yet another image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement security
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants