Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated Makefile, docs to install without errors #770

Merged
merged 2 commits into from
May 20, 2022
Merged

fix: Updated Makefile, docs to install without errors #770

merged 2 commits into from
May 20, 2022

Conversation

akashtadwai
Copy link
Contributor

Fixes #768

  • Updated Makefile to install without errors
  • Updated docs to verify whether robotoff is running properly after make dev

- Created docker network to run `make dev` without errors
- Updated docs accordingly to verify whether robotoff is running
@akashtadwai akashtadwai requested a review from a team as a code owner May 18, 2022 16:14
@akashtadwai akashtadwai changed the title Updated Makefile, docs to install without errors fix: Updated Makefile, docs to install without errors May 18, 2022
@alexgarel
Copy link
Member

@akashtadwai FYI, when you want to propose a feature, you should do it in a specific branch, not in master on your fork. This makes it more difficult for me to test your changes. Also this makes your project master use merge, when it could use fast-forward updates from origin master.

@akashtadwai
Copy link
Contributor Author

Thanks for the info @alexgarel. Should I create another branch and submit this pull request?

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool contrib @akashtadwai, thanks

@alexgarel alexgarel merged commit b5ab0e7 into openfoodfacts:master May 20, 2022
@alexgarel
Copy link
Member

Thanks for the info @alexgarel. Should I create another branch and submit this pull request?

It's ok for this PR, but I really advise you to:

  • either remove / recreate your fork (and always work in branches from there on) --> simpler option
  • either remove / recreate your master branch on your fork: (I'm not sure 100% of this sequence…)
git checkout -b tmp-branch 
git branch -D master
git fetch upstream
git checkout upstream/master 
git checkout -b master --track origin/master
git push -f
git branch -D tmp-branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Makefile error while installing robotoff
2 participants