Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php 8.4 compatibility #103

Open
sairiz opened this issue Dec 19, 2024 · 14 comments
Open

php 8.4 compatibility #103

sairiz opened this issue Dec 19, 2024 · 14 comments
Labels
help wanted Extra attention is needed

Comments

@sairiz
Copy link

sairiz commented Dec 19, 2024

Describe the bug
Hi, i stumble upon problem seeding the database during a migrate:fresh
After so many checks, i discovered the seeding isnt working in php 8.4

To Reproduce
Steps to reproduce the behavior:

  1. Use php 8.4
  2. Install new Laravel 11
  3. Composer require nnjeim/world
  4. php artisan world:install

Expected behavior
Installation and seeding normally

Additional context
Seeding didnt run at all. It works just fine in php 8.3

@nnjeim
Copy link
Owner

nnjeim commented Dec 20, 2024

@sairiz
Thank you for your input. I have followed your instructions for testing the package with Laravel 11 and php 8.4
All works fine on my end.
I have published the release 1.1.32

if following the upgrade you still have issues with php 8.4 please share the error here

@sairiz
Copy link
Author

sairiz commented Dec 21, 2024

Thanks for the feedback. I tried again on fresh laravel installation.
I am using herd so all setups are pretty standard.

Screenshot 2024-12-21 at 2 43 04 PM

@nnjeim
Copy link
Owner

nnjeim commented Dec 23, 2024

@sairiz please publish the world resources as below

php artisan vendor:publish --tag=world --force

@nnjeim nnjeim added the help wanted Extra attention is needed label Dec 23, 2024
@sairiz
Copy link
Author

sairiz commented Dec 23, 2024

PHP 8.4 (Herd - MacOS)

Screenshot 2024-12-24 at 12 30 19 AM

The database was migrated but no seeding happened. There is no error log offered either.

PHP 8.3 (Herd - MacOS)
Screenshot 2024-12-24 at 12 35 26 AM

Work as expected on php 8.3

@nnjeim
Copy link
Owner

nnjeim commented Dec 30, 2024

@sairiz
I re-run my testing and i have attached screenshots illustrating the steps

PHP version 8.4

Screenshot 2024-12-30 at 09 14 53

Artisan version 11

Screenshot 2024-12-30 at 09 15 45

The database was dropped then i re-installed world

Screenshot 2024-12-30 at 09 15 21

the database was seeded

Screenshot 2024-12-30 at 09 16 04

The endpoint is up and running

Screenshot 2024-12-30 at 09 18 14

@nnjeim
Copy link
Owner

nnjeim commented Dec 30, 2024

@sairiz despite the fact that my tests are positive would you please check Laravel logs for any error on your end?

@zishanj
Copy link

zishanj commented Jan 1, 2025

@sairiz please publish the world resources as below

php artisan vendor:publish --tag=world --force

@sairiz I was also facing this same error but after publishing the world resources and then executing install, it works perfectly.

image

@nnjeim
Copy link
Owner

nnjeim commented Jan 3, 2025

@sairiz @zishanj

I will explore on the possibility to have a bug in the install action. It is supposed to publish the config files prior to seeding.
Thank you both for your input

@JamesDavis7
Copy link

Exactly the same thing happening on my end.

Ran through all the install steps as instructed. The tables are migrated but nothing is seeded.

@nnjeim
Copy link
Owner

nnjeim commented Jan 14, 2025

@JamesDavis7 can you please try the below
php artisan vendor:publish --tag=world --force

i think the issue is that the config file is not publish.

please let me know if this will work

@JamesDavis7
Copy link

Tried that twice and still no luck. Simply not seeding.

@jjohanr
Copy link

jjohanr commented Jan 17, 2025

PLEASE HELP WITH THIS ERROR
LARAVEL 11
php 8.2.4
Image

@nnjeim
Copy link
Owner

nnjeim commented Jan 17, 2025

@jjohanr
please try this
php artisan vendor:publish --tag=world --force
then run the seeder

@jjohanr
Copy link

jjohanr commented Jan 18, 2025

any settings I'm missing?

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants