feat: improve garm-provider dev setup and adjust docs for new garm v0.1.5 #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafalgalaw
requested review from
bavarianbidi,
maigl and
H777K
as code owners
rafalgalaw
force-pushed
the
feat/garm-dev-setup-and-docs-v0.1.5
branch
2 times, most recently
from
e2cb200 to
d4ca9da
Compare
rafalgalaw
force-pushed
the
feat/garm-dev-setup-and-docs-v0.1.5
branch
from
d4ca9da to
63189f9
Compare
| @@ -0,0 +1,108 @@ | |||
| # nonk8s | |||
There was a problem hiding this comment.
what does nonk8s mean here?
| * **Repository permissions**: | ||
| * `Administration: Read & write` - needed to generate JIT config/registration token, remove runners, etc. | ||
| * `Metadata: Read-only` - automatically enabled by above | ||
| * `Webhooks: Read & write` - needed to install webhooks on repositories |
There was a problem hiding this comment.
Webhook permissions aren't required yet, as it's not implemented on the operator
| * `Webhooks: Read & write` - needed to install webhooks on repositories | ||
| * **Organization permissions**: | ||
| * `Self-hosted runners: Read & write` - needed to manage runners in an organization | ||
| * `Webhooks: Read & write` - needed to install webhooks on organizations |
There was a problem hiding this comment.
Webhook permissions aren't required yet, as it's not implemented on the operator
| @@ -3,8 +3,7 @@ | |||
| .idea | |||
| /bin/ | |||
| /hack/bin/garm-provider-k8s | |||
| /hack/local-development/kubernetes/configmap.yaml | |||
| /hack/local-development/kubernetes/garm-operator-all.yaml | |||
There was a problem hiding this comment.
do we really want to track the garm-operator-all.yaml in this repo?
We just fetch the file from the operator repo and it's only needed during development-face (which is then covered by our development description)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #71
see title