Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CD: Upload ZIP files for release tags in a separate GCS folder #45

Open
xnyo opened this issue Feb 25, 2025 · 1 comment · May be fixed by #46
Open

CD: Upload ZIP files for release tags in a separate GCS folder #45

xnyo opened this issue Feb 25, 2025 · 1 comment · May be fixed by #46
Assignees
@xnyo
Labels
enhancement New feature or request

Comments

@xnyo
Copy link
Member

xnyo commented Feb 25, 2025 •
edited
Loading

Due to how SSS currently works with provisioned plugins, we have to upload a separate artifact for tagged releases.

The GCS URL could be: {BUCKET}/{PLUGIN_ID}/{VERSION}/tags/{PLUGIN_ID}-{TAG}.zip

Slack thread with discussion: https://raintank-corp.slack.com/archives/C01C4K8DETW/p1740067230244959
@xnyo xnyo added the enhancement New feature or request label Feb 25, 2025
@xnyo xnyo self-assigned this Feb 25, 2025
@xnyo
Copy link
Member Author

xnyo commented Feb 25, 2025 •
edited
Loading

IIRC this was actually done in Drone but was accidentally removed during the GHA migration:

https://github.com/grafana/grafana-drone-extension/blob/411172f4e3681acb2e78d2ed0d42ba8e1fc093c7/pluginjson/pipeline-deploy.go#L142-L153

This should be kept for backwards compatibility until https://github.com/grafana/grafana-community-team/issues/220 is done

@xnyo xnyo moved this from 📬 Triage to 🧑‍💻 In development in Plugins Platform / Grafana Community Feb 25, 2025
@xnyo xnyo linked a pull request Feb 25, 2025 that will close this issue
Draft
@NWRichmond NWRichmond mentioned this issue Feb 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xnyo xnyo

Labels
enhancement New feature or request
Projects
Plugins Platform / Grafana Community
Status: 🧑‍💻 In development
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: CD: Upload ZIP files to a dedicated release folder grafana/plugin-ci-workflows
1 participant
@xnyo