Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example of iterating through pull request changed files in ruby. #196

Open
CatGirlsAreLife opened this issue Jul 26, 2018 · 0 comments

Comments

@CatGirlsAreLife
Copy link

CatGirlsAreLife commented Jul 26, 2018

I currently got this much done on it myself, however with not knowing ruby much at all I am not sure if I coded it all right. The code lies at https://github.com/Elskom/CI/blob/master/CI.rb. Yes it is formatted like the building a CI server example but with pull request label check for "skip news", and a "Misc/NEWS" entry check for if a new file was added there. I am not sure how I can filter it though to where that check only works with new entry files, not modified or deleted ones unless all of them merged to a single file (like right before a release). I would also love to be able to have my CI read comments from repo /org admins though for things like "I approve this" where the CI then approves the changes and then waits for "merge squashed/rebased/commit". I personally think it would be great to have an example like that tbh. And yes, feel free to use the code I got so far on an example, I don’t mind if you guys even linked to it too. Also I thought those octocat stuff was some sort of photoshopped thing. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant