Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ability to set controller.sync.timeout.seconds from values.yaml #3158

Open
myoung34 opened this issue Feb 4, 2025 · 1 comment
Open
Labels
argo-cd enhancement New feature or request

Comments

@myoung34
Copy link

myoung34 commented Feb 4, 2025

Is your feature request related to a problem?

The new sync timeout options in 2.14 are great

The usage is global though, so it has to go to configmap/argocd-cmd-params-cm

Related helm chart

argo-cd

Describe the solution you'd like

There's no way to set controller.sync.timeout.seconds from values.yaml

In the interim I had to capture and version control configmap/argocd-cmd-params-cm by setting

  valuesInline:
    configs:
      params:
        create: false

See here

Instead I'd like to just be able to set additional values for configmap/argocd-cmd-params-cm from values.yaml

Describe alternatives you've considered

No response

Additional context

No response

@myoung34 myoung34 added the enhancement New feature or request label Feb 4, 2025
@yu-croco
Copy link
Collaborator

yu-croco commented Feb 12, 2025

Hi @myoung34

There's no way to set controller.sync.timeout.seconds from values.yaml

Though it's not on values.yaml but you can configure like below and it works (any values under configs.params will be rendered in argocd-cmd-params-cm.yaml).

configs:
  params:
    controller.sync.timeout.seconds: "1"

*result of helm template

# Source: argo-cd/templates/argocd-configs/argocd-cmd-params-cm.yaml
apiVersion: v1
kind: ConfigMap
metadata:
  name: argocd-cmd-params-cm
  namespace: default
  labels:
    helm.sh/chart: argo-cd-7.8.2
    app.kubernetes.io/name: argocd-cmd-params-cm
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/component: server
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/part-of: argocd
    app.kubernetes.io/version: "v2.14.2"
data:
  # ....
  controller.sync.timeout.seconds: "1"
  # ....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-cd enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants